bugfix: gravity vector now rotated to target_frame prior to removal#892
Open
HaoguangYang wants to merge 1 commit into
Open
bugfix: gravity vector now rotated to target_frame prior to removal#892HaoguangYang wants to merge 1 commit into
HaoguangYang wants to merge 1 commit into
Conversation
…to removal from acc_tmp.
Collaborator
|
Thanks for this. It looks like it needs to be uncrustified, though: https://build.ros2.org/job/Rpr__robot_localization__ubuntu_noble_amd64/9/testReport/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses Issue #846 when integrating IMU data for odometry.
In the previous version, the gravity vector was rotated to IMU frame instead of target_frame prior to gravity removal. However, acc_tmp has already been transformed into target_frame. This causes inconsistency and may have caused issue #846 .