Skip to content

Comments

Refactoring action pushing to ReadMe bidir-sync repositories and update source to remove circular refs #203

Open
gricher-crto wants to merge 2 commits intomainfrom
preview-apiref-refactoring
Open

Refactoring action pushing to ReadMe bidir-sync repositories and update source to remove circular refs #203
gricher-crto wants to merge 2 commits intomainfrom
preview-apiref-refactoring

Conversation

@gricher-crto
Copy link
Contributor

  • Those Github actions are currently unused
  • Only covers preview and RM + MS

What is missing (not covered):

  • fix reimport with respect to operationId changes and addition/removal of operation
  • align naming of OAS in both project
  • push authendpoint OAS from common source

@gricher-crto gricher-crto changed the title Merge two actions pushing to the ReadMe bidir(sync repositories and update source to remove circular refs Refactoring action pushing to ReadMe bidir-sync repositories and update source to remove circular refs Feb 11, 2026
- api: MarketingSolutions
ssh_secret: MARKETING_SOLUTIONS_PUBLIC_API_DOC_REPO_PRIVATE_KEY
repo: marketing-solutions-public-api-doc
oas_dest_name: criteo-api-1.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alternative, that would lead to less complexity here, would be to rename the file in the destination repo, to have the name in both. I don't remember the details, but IIRC it should be rather straightforward. What about looking into it? (OTHO it can definitely be done afterwards, so that's just a suggestion)

runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, I wasn't aware of this feature; that's pretty near!

Btw, do you have clues whether both configs would run sequentially or in parallel?
I remember that Readme has some concurrency issues so we should ensure both don't run at the same time. (btw, not too sure either if it's enough to just have the 2 conf runs one directly after the other, or if it should sleep a bit in otder to let Readme processing of the first config be completed? 🤔 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants