Refactoring action pushing to ReadMe bidir-sync repositories and update source to remove circular refs #203
Refactoring action pushing to ReadMe bidir-sync repositories and update source to remove circular refs #203gricher-crto wants to merge 2 commits intomainfrom
Conversation
| - api: MarketingSolutions | ||
| ssh_secret: MARKETING_SOLUTIONS_PUBLIC_API_DOC_REPO_PRIVATE_KEY | ||
| repo: marketing-solutions-public-api-doc | ||
| oas_dest_name: criteo-api-1.json |
There was a problem hiding this comment.
An alternative, that would lead to less complexity here, would be to rename the file in the destination repo, to have the name in both. I don't remember the details, but IIRC it should be rather straightforward. What about looking into it? (OTHO it can definitely be done afterwards, so that's just a suggestion)
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: |
There was a problem hiding this comment.
nice, I wasn't aware of this feature; that's pretty near!
Btw, do you have clues whether both configs would run sequentially or in parallel?
I remember that Readme has some concurrency issues so we should ensure both don't run at the same time. (btw, not too sure either if it's enough to just have the 2 conf runs one directly after the other, or if it should sleep a bit in otder to let Readme processing of the first config be completed? 🤔 )
What is missing (not covered):