Skip to content

Fix error when using certain config values in Cargo.toml#1183

Merged
bors[bot] merged 1 commit into
cross-rs:mainfrom
Emilgardis:fix-1182
Jan 6, 2023
Merged

Fix error when using certain config values in Cargo.toml#1183
bors[bot] merged 1 commit into
cross-rs:mainfrom
Emilgardis:fix-1182

Conversation

@Emilgardis
Copy link
Copy Markdown
Member

pre-build = "file" and image.toolchain had a bad serialization, this fixes that

Closes #1182

`pre-build = "file"` and `image.toolchain` had a bad serialization
@Emilgardis Emilgardis requested a review from a team as a code owner January 6, 2023 02:55
@Emilgardis
Copy link
Copy Markdown
Member Author

bors r+

bors Bot added a commit that referenced this pull request Jan 6, 2023
1183: Fix error when using certain config values in Cargo.toml r=Emilgardis a=Emilgardis

`pre-build = "file"` and `image.toolchain` had a bad serialization, this fixes that

Closes #1182


Co-authored-by: Emil Gardström <emil.gardstrom@gmail.com>
@Emilgardis
Copy link
Copy Markdown
Member Author

bors cancel

@bors
Copy link
Copy Markdown
Contributor

bors Bot commented Jan 6, 2023

Canceled.

@Emilgardis Emilgardis added the no-ci-targets PRs that do not affect or should skip any cross-compilation targets. label Jan 6, 2023
@Emilgardis
Copy link
Copy Markdown
Member Author

bors r+

@bors
Copy link
Copy Markdown
Contributor

bors Bot commented Jan 6, 2023

Build succeeded:

@bors bors Bot merged commit 8c86a98 into cross-rs:main Jan 6, 2023
@Emilgardis Emilgardis deleted the fix-1182 branch January 6, 2023 18:38
@Emilgardis Emilgardis added this to the v0.2.5 milestone Feb 4, 2023
@Emilgardis Emilgardis mentioned this pull request Feb 4, 2023
bors Bot added a commit that referenced this pull request Feb 4, 2023
1201: Release v0.2.5 r=Emilgardis a=Emilgardis

See #962 (comment)

includes

ee3c972 #962
fc3df66 #1166
33ee940 in #997
81c1e59 #950
6a57d01 #1183

Co-authored-by: Emil Gardström <emil.gardstrom@gmail.com>
Co-authored-by: Alex Huszagh <ahuszagh@gmail.com>
Co-authored-by: Taiki Endo <te316e89@gmail.com>
bors Bot added a commit that referenced this pull request Feb 4, 2023
1201: Release v0.2.5 r=Emilgardis a=Emilgardis

See #962 (comment)

includes

ee3c972 #962
fc3df66 #1166
33ee940 in #997
81c1e59 #950
6a57d01 #1183

Co-authored-by: Emil Gardström <emil.gardstrom@gmail.com>
Co-authored-by: Alex Huszagh <ahuszagh@gmail.com>
Co-authored-by: Taiki Endo <te316e89@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-ci-targets PRs that do not affect or should skip any cross-compilation targets.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Config in Cargo.toml: invalid type: map, expected a string for key target.x86_64-unknown-freebsd.image

1 participant