fix(docs): Remove duplicate call to GetObservedCompositeResource in docs#46
Merged
phisco merged 1 commit intocrossplane:mainfrom Oct 12, 2023
Merged
Conversation
Signed-off-by: Bryan Nobuhara <bnobuhara@gmail.com>
Mitsuwa
force-pushed
the
duplicate-getcomposed-readme
branch
from
b60b4fa to
ccc779d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
I believe this is a mistaken duplicate line in the
README.md. The comment and call above seem to be for gettingspec.widgetsas well as the error check below. I believe thisline, was accidently copied from line #30 above and should be removed because it is confusing here
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
this is a readme change