Skip to content

chore(audit): spotbugs corrections#1450

Open
andrewazores wants to merge 1 commit intocryostatio:mainfrom
andrewazores:audit-spotbugs
Open

chore(audit): spotbugs corrections#1450
andrewazores wants to merge 1 commit intocryostatio:mainfrom
andrewazores:audit-spotbugs

Conversation

@andrewazores
Copy link
Copy Markdown
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to #1423

Description of the change:

Fixes missed spotbugs issues. It seems the spotbugs CI check runs in the wrong context and actually checks the base branch (ie main), not the PR branch. See #1439

@andrewazores andrewazores added chore Refactor, rename, cleanup, etc. safe-to-test labels Apr 1, 2026
@andrewazores andrewazores requested a review from a team April 1, 2026 17:58
@andrewazores
Copy link
Copy Markdown
Member Author

/build_test

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

Workflow started at 4/1/2026, 1:59:22 PM. View Actions Run.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

No OpenAPI schema changes detected.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

No WebSocket notifications schema changes detected.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

No GraphQL schema changes detected.

@andrewazores
Copy link
Copy Markdown
Member Author

/build_test

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

Workflow started at 4/1/2026, 2:07:33 PM. View Actions Run.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

CI build: Integration tests pass ✅
https://github.com/cryostatio/cryostat/actions/runs/23863124447

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

No WebSocket notifications schema changes detected.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

No OpenAPI schema changes detected.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

No GraphQL schema changes detected.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

CI build: Unit tests pass ✅
https://github.com/cryostatio/cryostat/actions/runs/23863124447

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

CI build: Integration tests pass ✅
https://github.com/cryostatio/cryostat/actions/runs/23863474096

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

CI build: Unit tests pass ✅
https://github.com/cryostatio/cryostat/actions/runs/23863474096

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Refactor, rename, cleanup, etc. safe-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants