Skip to content

feat(x/tx): sync with upstream#836

Merged
yihuang merged 4 commits into
crypto-org-chain:release/v0.50.xfrom
yihuang:release/v0.50.x
Oct 14, 2024
Merged

feat(x/tx): sync with upstream#836
yihuang merged 4 commits into
crypto-org-chain:release/v0.50.xfrom
yihuang:release/v0.50.x

Conversation

@yihuang
Copy link
Copy Markdown

@yihuang yihuang commented Oct 7, 2024

Description

I did a reset to upstream release/v0.50.x branch, then cherry-pick pull request cosmos#21944 and cosmos#22088

(cherry picked from commit dbf6cdb)


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@github-actions github-actions Bot added the C:x/tx label Oct 7, 2024
@yihuang yihuang changed the title feat(x/tx): support bytes field as signer (#21850) feat(x/tx): sync with upstream Oct 7, 2024
@yihuang yihuang requested a review from mmsqe October 7, 2024 03:14
@yihuang yihuang enabled auto-merge (squash) October 7, 2024 03:17
@mmsqe mmsqe disabled auto-merge October 7, 2024 03:21
Comment thread x/tx/signing/aminojson/encoder.go Outdated
@yihuang yihuang marked this pull request as draft October 7, 2024 03:44
@mmsqe mmsqe marked this pull request as ready for review October 14, 2024 07:38
HuangYi added 3 commits October 14, 2024 15:50
(cherry picked from commit 2d40cc1)

fix half conflicts and revert tests

conflicts
@yihuang yihuang enabled auto-merge (squash) October 14, 2024 07:52
@yihuang yihuang merged commit ba8668a into crypto-org-chain:release/v0.50.x Oct 14, 2024
@yihuang yihuang deleted the release/v0.50.x branch October 14, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants