Fix suitableForSymExec precedence inversion#1580
Open
elopez wants to merge 5 commits into
Open
Conversation
`not $ null m.inputs && ...` parsed as `not (null m.inputs && ...)`, negating the whole conjunction: the dynamic-argument guard never fired (so bytes/string/dynamic-array methods were handed to the symbolic encoder, which throws). Bind `not` to the emptiness check alone so the filter means what it says: explore methods that have arguments, none dynamic, not opted out.
Collaborator
|
Blocked by argotorg/hevm#1057. Once that's merged, we will change/remove this check to allow dynamic-argument inputs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not $ null m.inputs && ...parsed asnot (null m.inputs && ...), negating the whole conjunction: the dynamic-argument guard never fired (so bytes/string/dynamic-array methods were handed to the symbolic encoder, which throws).Bind
notto the emptiness check alone so the filter means what it says: explore methods that have arguments, none dynamic, not opted out.