Skip to content

Remove obsolete solc AST CLI flag#3024

Open
nhatdo9825-cmyk wants to merge 1 commit into
crytic:masterfrom
nhatdo9825-cmyk:fix/remove-solc-ast-flag
Open

Remove obsolete solc AST CLI flag#3024
nhatdo9825-cmyk wants to merge 1 commit into
crytic:masterfrom
nhatdo9825-cmyk:fix/remove-solc-ast-flag

Conversation

@nhatdo9825-cmyk

Copy link
Copy Markdown

Fixes #2501.

This removes the obsolete --solc-ast CLI flag, whose help text suggested that Slither could accept a JSON AST directly. Maintainer discussion in #2501 notes that this support was removed and should stay unavailable unless it is re-added properly in crytic-compile.

The PR also removes the CLI smoke test for that deprecated flag so the test suite no longer preserves the misleading option.

Validation:

  • python -m py_compile slither_main_.py
  • git diff --check
  • rg solc_ast/--solc-ast/solc-ast across slither, scripts, tests, docs, README.md, pyproject.toml

@nhatdo9825-cmyk nhatdo9825-cmyk requested a review from smonicas as a code owner May 16, 2026 15:41
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug-Candidate]: --solc-ast flag does nothing and all

2 participants