Logs message instead of error if no versions exist for solc-select versions
#154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xalpharush
reviewed
Feb 2, 2023
solc_select/__main__.py
Outdated
| print(f"{version} (current, set by {source})") | ||
| else: | ||
| print(version) | ||
| if installed_versions(): |
Contributor
There was a problem hiding this comment.
Can you store the result and not call installed_versions twice
Contributor
Author
There was a problem hiding this comment.
fixed! thanks
0xicingdeath
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #152
During the execution of
solc-select versionsa conditional statement has now been added to preview if any solc-select versions have been installed prior before proceeding, if the check fails, the code block responsible for looking up and printing installed versions is skipped and an informational message is logged.