Skip to content

Standardize errors to use argsparse instead of print and sysexit #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xicingdeath merged 1 commit into from
Nov 30, 2021
Merged

Standardize errors to use argsparse instead of print and sysexit #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 10 additions & 15 deletions solc_select/solc_select.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@

def halt_old_architecture(path: Path):
if not Path.is_file(path):
print("solc-select is out of date. Please run `solc-select update`")
sys.exit(1)
raise argparse.ArgumentTypeError(
"solc-select is out of date. Please run `solc-select update`"
)


def upgrade_architecture():
Expand All @@ -30,29 +31,26 @@ def upgrade_architecture():
install_artifacts(currently_installed)
print("solc-select is now up to date! 🎉")
else:
print("solc-select is already up to date")
sys.exit(1)
raise argparse.ArgumentTypeError("solc-select is already up to date")
else:
print("Run `solc-select install --help` for more information")
sys.exit(1)
raise argparse.ArgumentTypeError("Run `solc-select install --help` for more information")


def current_version():
version = os.environ.get("SOLC_VERSION")
source = "SOLC_VERSION"
if version:
if version not in installed_versions():
print(
raise argparse.ArgumentTypeError(
f"Version '{version}' not installed (set by {source}). Run `solc-select install {version}`."
)
sys.exit(1)
else:
source = solc_select_dir.joinpath("global-version")
if Path.is_file(source):
with open(source) as f:
version = f.read()
else:
print(
raise argparse.ArgumentTypeError(
"No solc version set. Run `solc-select use VERSION` or set SOLC_VERSION environment variable."
)
return None
Expand Down Expand Up @@ -118,13 +116,11 @@ def switch_global_version(version):
f.write(version)
print("Switched global version to", version)
elif version in get_available_versions():
print(
raise argparse.ArgumentTypeError(
f"You need to install '{version}' prior to using it. Use `solc-select install {version}`"
)
sys.exit(1)
else:
print(f"Unknown version '{version}'.")
sys.exit(1)
raise argparse.ArgumentTypeError(f"Unknown version '{version}'")


def valid_version(version):
Expand Down Expand Up @@ -189,6 +185,5 @@ def soliditylang_platform():
elif sys.platform == "win32" or sys.platform == "cygwin":
platform = "windows-amd64"
else:
print("Unsupported platform.")
sys.exit(1)
raise argparse.ArgumentTypeError("Unsupported platform")
return platform