Do not delete leading empty lines#833
Open
thinca wants to merge 1 commit into
Open
Conversation
Source code may have magic comments. ``` # frozen_string_literal: true # == Schema Information # # Table name: foo # # id :integer not null, primary key # created_at :datetime # updated_at :datetime # class Foo < ActiveRecord::Base end ``` In this case, the blank line before the annotation should not be erased by `annotate --delete`. Expected: ``` # frozen_string_literal: true class Foo < ActiveRecord::Base end ``` But actual: ``` # frozen_string_literal: true class Foo < ActiveRecord::Base end ``` This change fixes it.
546a6a6 to
e530e17
Compare
BryanH
approved these changes
Dec 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source code may have magic comments.
In this case, the blank line before the annotation should not be erased by
annotate --delete.Expected:
But actual:
This change fixes it.