Skip to content

Conversation

@bartlangelaan
Copy link
Contributor

I'm not that familiar with this module, but this seems to fix #38.

It uses the internal $$typeof property from React. I didn't test it with Preact, but I couldn't find anything about forwardRef in Preact so I think it doesn't exist yet.

@codecov
Copy link

codecov bot commented Aug 10, 2018

Codecov Report

Merging #39 into master will increase coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #39     +/-   ##
=========================================
+ Coverage   95.87%   96.07%   +0.2%     
=========================================
  Files           1        1             
  Lines          97      102      +5     
  Branches       29       31      +2     
=========================================
+ Hits           93       98      +5     
  Misses          4        4
Impacted Files Coverage Δ
src/index.js 96.07% <100%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c04e8c1...0d9f69e. Read the comment docs.

@ctrlplusb
Copy link
Owner

Awesome! Thanks for taking this on. I will try review soon. 🤘

@bartlangelaan
Copy link
Contributor Author

That would be awesome! This is blocking upgrading some of our websites to the latest version of React.

@ctrlplusb
Copy link
Owner

Nice work. 👍

@ctrlplusb ctrlplusb merged commit e2e64e3 into ctrlplusb:master Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

React.forwardRef is not supported

2 participants