Refactor passes: dead code, ThreadView split, shared Insights CSS, provider process helper

Audit of main @ 6967e43 (knip, jscpd, eslint no-unused-vars, file sizes) turned up four behaviour-preserving passes that touch disjoint files, run as parallel workers.

Findings

Size: ThreadView.tsx 9.4k lines (ThreadView component 4.4k, plus ~5k of sibling components), runner.js 9.3k (createRunner closure 8.6k), worktrees.js 6.8k, devCoder.ts 6.7k, services.js 5.8k.
Dead code (production-unused, some kept alive only by tests): crewIntegration.ts label helpers (6), uiPrefs verbose-tool-cards / run-duration / vim getters, SNOOZE_PRESETS, clearPaneLayouts, chunkForPath, browseQueryForSubmit, worktrees.js gitOutForDiff, orchServer unused import, automations PRESETS, memory-sup boundCoderMemoryUrl, session-record configureSessionRecord.
Duplication (~1% overall): provider adapters copy the JSON-lines child-process plumbing (cursor/muse/opencode/codex/claude/grok, about 300 lines). Insights-style views copy ~400 lines of page CSS (Activity/Insights/Fleet/Digest/Kanban/Planboard/PrList).

Passes

A: dead code removal
B: move ThreadView.tsx sibling components into src/components/thread/
C: shared page CSS for the Insights views
D: shared JSON-lines process helper for provider adapters

Not now

Splitting createRunner (8.6k-line closure) and the ThreadView component body: worth doing, but they need a design pass (state threading), not a mechanical move. Follow-up once A–D land.

All four passes are verified and open as PRs. They touch disjoint files, and each is mergeable on its own:

A, dead code: Remove production-dead code (#1447 pass A) #1448 (+10 / −600)
B, ThreadView split (9,442 → 5,042 lines): Split ThreadView.tsx: move sibling components to src/components/thread/ (#1447 pass B) #1449. It's a pure move, checked line by line.
C, shared page CSS: Share page scaffolding CSS across the Insights-style views (#1447 pass C) #1450 (+386 / −737). Pixel-identical across 7 views in both themes.
D, runJsonLines and overlayHomes provider helpers: One JSON-lines process helper for the provider adapters (#1447 pass D) #1451 (+545 / −1,194). Electron 4109/4109.

Follow-ups, not started: split createRunner (8.6k-line closure) and the ThreadView component body. Both need a design pass on how state flows through them before they can be split mechanically.

Merge pull request #1448 from currentbits/coder/refactor-a-remove-dea…

Merge pull request #1449 from currentbits/coder/refactor-b-split-thre…

Merge pull request #1450 from currentbits/coder/refactor-c-shared-ins…

Merge pull request #1451 from currentbits/coder/refactor-d-shared-pro…

Round 2

Four more passes, all behaviour-preserving. None of them touch files in the open round-1 PRs (#1448–#1451).

E: split electron/services.js (5.8k lines, 175 flat functions) into domain modules. services.js stays as the barrel, so require("./services") callers don't change.
F: move ThreadCard (673 lines), SettledRow, the status helpers and the smaller components out of Sidebar.tsx into src/components/sidebar/, verbatim, the same way pass B did for ThreadView.
G: createRunner has 123 inner functions. Lift the ones that don't touch closure state into a module, and write a design note on how to split the rest (state map plus proposed module seams).
H: SettingsModal.tsx (3.2k lines): give each settings pane its own component file under src/components/settings/.

Round 1 merged (#1448–#1451). Round 2 is verified and open:

E, services.js 5,824 → 348 lines (10 domain modules, same 161 exports): Split services.js into domain modules behind the same barrel (#1447 pass E) #1452
F, Sidebar.tsx 4,752 → 3,328 lines: Split Sidebar.tsx: move sibling components to src/components/sidebar/ (#1447 pass F) #1453
G, 11 closure-free createRunner helpers lifted, plus the runner split design (docs/superpowers/specs/2026-10-04-runner-split-design.md): Lift closure-free createRunner helpers, add the runner split design (#1447 pass G) #1454
H, SettingsModal.tsx 3,179 → 801 lines (7 pane files, 11 screenshots pixel-identical): One component file per Settings pane (#1447 pass H) #1455

Round 3: the createRunner split, per G's design

Safety tests first: Claude idle reap and LRU eviction, and CI-workflow sign-off failing closed. Today neither is covered before the steps that move that code.
Step 1: the create<Seam>(ctx) mechanism, plus the watchdogs seam. This is stacked on Lift closure-free createRunner helpers, add the runner split design (#1447 pass G) #1454.
Steps 2–6 (ask/btw, turn setup, subagents, session recording, Claude keep-alive) in parallel once step 1 has landed the ctx wiring.
Steps 7–11 one after another (verify gate, quota, notices/crew, permissions, provider runs).

Round 3 progress

Safety tests: Safety tests: Claude keep-alive reap and CI sign-off fail-closed (#1447) #1457. They catch all 4 deliberate mutations (idle cap, idle reap, request-id check, single-use sign-off). Electron suite 4125/4125.
Step 1, seam ctx + watchdogs: Runner split step 1: seam ctx + watchdogs module (#1447, stacked on #1454) #1456, stacked on Lift closure-free createRunner helpers, add the runner split design (#1447 pass G) #1454. This step found that seams must be flat electron/runner-<seam>.js files, because the packagers copy only electron/*.js. The design note is corrected to match.
Steps 2–5, ask/btw, turn setup, subagents, session recording: Runner split steps 2–5: ask/btw, turn setup, subagents, session recording (#1447, stacked on #1456) #1458, stacked on Runner split step 1: seam ctx + watchdogs module (#1447, stacked on #1454) #1456. runner.js goes from 9,120 to 8,345 lines.
Step 6, Claude keep-alive: waits for Safety tests: Claude keep-alive reap and CI sign-off fail-closed (#1447) #1457 on main.
Steps 7–11: verify gate, quota, notices/crew, permissions, provider runs, one after another.

Merge order: #1457, #1454, #1456, #1458. #1452, #1453 and #1455 are independent.

CI note: test (windows-latest) intermittently times out on the whole test/sidebar.test.tsx file. It has happened 3 times today, including on electron-only PRs. That's a pre-existing flake, filed as a suggested-work chip.

test(runner): CI sign-off is not honoured during a notice-driven turn (…

Round 3 complete: the createRunner split

electron/runner.js goes from 9,321 to 2,628 lines. 18 flat runner-*.js modules now hold the code that moved out; runnerHelpers.js holds pure helpers and the other 17 are create<Seam>(ctx) factories. Every step is verified: verbatim moves, eager ctx deps checked by script, construction order, the full electron suite, typecheck and the real-Electron smoke test.

Safety tests: Claude keep-alive reap and CI sign-off fail-closed (#1447) #1457: safety tests, Claude idle reap and CI sign-off fail-closed. 5 of 5 planted bugs are caught, including the auto-turn check.
Lift closure-free createRunner helpers, add the runner split design (#1447 pass G) #1454: closure-free helpers and the design note
Runner split step 1: seam ctx + watchdogs module (#1447, stacked on #1454) #1456: step 1, ctx and watchdogs. It established flat electron/runner-<seam>.js, because the packagers copy only electron/*.js.
Runner split steps 2–5: ask/btw, turn setup, subagents, session recording (#1447, stacked on #1456) #1458: steps 2–5 (ask/btw, turn setup, subagents, session recording)
Runner split seams 6–10: claude sessions, verify gate, quota, notices, permissions (#1447, stacked on #1458) #1459: seams 6–10 (claude sessions, verify gate, quota, notices/crew, permissions)
Runner split seam 11: one module per provider run (#1447, stacked on #1459) #1460: seam 11, one module per provider run

Merge order: #1457 → #1454 → #1456 → #1458 → #1459 → #1460. Round 2's #1452, #1453 and #1455 are independent.

Still open from the original audit: the ThreadView component body (~4.4k lines) and the other large React components (Sidebar body ~3k, useCoder ~3.5k, Composer ~3k). These need hook extraction, not file moves.

Round 4: hook extraction in the big React components

Three workers in parallel, one per file. None of the open PRs touch these files.

I: useCoder.ts (4,510 lines, one ~3,500-line hook). Split it into domain sub-hooks that useCoder composes; the UseCoderResult shape stays identical.
J: ThreadView.tsx (5,042 lines, a ~4,400-line component). Extract custom hooks for closed state groups (scroll/stick-to-bottom, header, git/PR state, …).
K: Composer.tsx (3,531 lines, a ~3,000-line component). Extract custom hooks (speech, attachments, mentions/slash menus, vim, …).

The rule that keeps this behaviour-preserving: React runs effects in declaration order. Only contiguous hook groups move, and each new custom hook is called exactly where its group was. Each worker also writes a short state map and seam plan for its component under docs/superpowers/specs/, and stops at whatever can't be moved safely.

Later: the Sidebar component body (after #1453) and App.tsx.

Round 4 complete: hook extraction

Each PR was checked with a script: once the custom hooks are expanded, the component has the same effects in the same order as on main. Each is also a pure move ignoring indentation, and passes typecheck, vite build and renderer 2701/2701.

ThreadView: extract nine custom hooks into src/components/thread/ (#1447 pass J) #1461: ThreadView, 9 hooks (5,042 → 4,369 lines). The autoscroll/thread-switch screenshots are pixel-identical to main.
useCoder: split into 12 domain sub-hooks under src/coder/ (#1447 pass I) #1462: useCoder, 12 domain sub-hooks (4,510 → 2,119 lines). All 8 effects stay in the core, and the return object has the same 220 keys.
Composer: extract nine hooks and five components into src/components/composer/ (#1447 pass K) #1463: Composer, 9 hooks and 5 stateless components (3,531 → 2,659 lines). Menu, model picker and hero screenshots are pixel-identical. It stopped before the model picker, whose effects are interleaved with other concerns.

Round 5

L: electron/worktrees.js (6,757 lines, 159 flat functions). Split into flat worktrees-*.js domain modules behind the same exports, like Split services.js into domain modules behind the same barrel (#1447 pass E) #1452 did for services.
M: src/devCoder.ts (6,696 lines, the browser demo backend). Split by domain.
N: src/App.tsx (~2,500-line component). Extract hooks with the same effect-order rules as round 4.

Merge pull request #1472 from currentbits/coder/refactor-s-split-ipc-…

Round 6

Merged:

Split sidebar.test.tsx so each file fits the 20s per-file budget (fixes Windows CI timeouts, #1447 pass U) #1468 U: sidebar.test.tsx split so each file fits the 20 s per-file budget. This fixes the recurring Windows CI timeout.
Split cli-sessions.js into one module per provider (#1447 pass O) #1467 O: cli-sessions.js 2,566 → per-provider modules (42 exports, identical).
Split store.js: pure helpers and Store method groups into focused modules (#1447 pass P) #1469 P: store.js 4,185 → 2,052 lines. The real-store round-trip is byte-identical with the clock and ids frozen; the prototype descriptors are identical.
Split workflow.js: per-provider spawners and phase helpers into modules (#1447 pass R) #1470 R: workflow.js 2,557 → 1,106 lines (15 exports, identical; workflow tests 97/97).
Sidebar: extract 7 hooks and 7 components into src/components/sidebar/ (#1447 pass T) #1471 T: Sidebar 3,328 → 2,124 lines, with 7 hooks and 7 stateless components. The 14 effects keep their order; screenshots are identical.

Before merging, I combined all five on a throwaway branch: electron 4126/4126, renderer 2701/2701, typecheck, build and smoke A–E all pass. Main's tree after merging matches that branch exactly.

Merging once CI is green:

Split IPC_HANDLERS into per-namespace modules (#1447 pass S) #1472 S: IPC_HANDLERS split into 11 namespace modules (ipc.js 2,476 → 176). The 262-channel set and every handler's source are identical. The modules hold exactly 262 handlers, so none is duplicated. Verified merged onto current main: electron 4126/4126, typecheck including the sync-ipc-preload check, and smoke A–E.

Still left: ios-simulator.js (a 2,685-line factory closure, needs the runner-style ctx seams).

Merge pull request #1473 from currentbits/coder/refactor-v-split-ios-…

Split IPC_HANDLERS into per-namespace modules (#1447 pass S) #1472 S: IPC_HANDLERS split, merged. Main CI was green across all of round 6.
ios-simulator.js part 1: parsers to a module, 20 closure-free helpers lifted (#1447 pass V) #1473 V part 1: ios-simulator.js 3,244 → 2,781 lines. The parsers moved to ios-simulator-parse.js, 20 closure-free helpers were lifted, and the seam plan is in docs/superpowers/specs/2026-10-05-ios-simulator-split.md. The worker lost its session to a network error after this part. I verified and merged what was committed: exports identical, pure move, no lifted function touches closure state (checked by script), simulator tests 327/327, electron 4126/4126, smoke A–E.
V2: the seam extraction, following that plan. A fresh worker started from main 5a9c2698.

Merge pull request #1474 from currentbits/coder/refactor-v2-ios-simul…

Done: every file on the original list is split

ios-simulator.js part 2: seven seams into create<Seam>(ctx) modules (#1447 pass V2) #1474 V2: seven ios-simulator seams moved into create<Seam>(ctx) modules. ios-simulator.js goes 2,781 → 1,697 lines (3,244 → 1,697 including ios-simulator.js part 1: parsers to a module, 20 closure-free helpers lifted (#1447 pass V) #1473). Exports and the service's 32 return keys are identical; eager deps were checked by script; ESLint no-undef reports 0, so no seam reads closure state. Simulator tests 327/327, electron 4126/4126, smoke A–E.

File	Before	After
`electron/runner.js`	9,321	2,628
`electron/worktrees.js`	6,757	206
`src/devCoder.ts`	6,696	513
`electron/services.js`	5,824	348
`electron/store.js`	4,185	2,052
`src/useCoder.ts`	4,510	2,119
`src/components/ThreadView.tsx`	9,442	4,369
`src/components/Sidebar.tsx`	4,752	2,124
`electron/ios-simulator.js`	3,244	1,697
`src/components/Composer.tsx`	3,531	2,659
`src/components/SettingsModal.tsx`	3,179	801
`src/App.tsx`	2,732	2,022
`electron/cli-sessions.js`	2,566	~130
`electron/workflow.js`	2,557	1,106
`electron/ipc.js`	2,476	176

Also fixed along the way: the Windows sidebar.test.tsx timeout (#1468), plus new safety tests for CI sign-off fail-closed and Claude idle reap (#1457).

Known open flake, found today: macOS workflow.test.js "stopRun mid-analyze" waitFor timeout. It predates these changes; there's a suggested-work chip on the thread.

What's left is deliberate: the residues each spec documents (the ThreadView switch-reset effect, the useCoder core effects, the Composer model picker), which need behaviour-level changes rather than moves.

Correction to the table above: electron/cli-sessions.js on main is 187 lines (measured), not ~130.

Done: passes A–D merged (#1448–#1451). Closing in the 2026-10-09 board cleanup (#1532).

Navigation Menu

Repository navigation

Refactor passes: dead code, ThreadView split, shared Insights CSS, provider process helper #1447

Findings

Passes

Not now

Round 2

Round 3: the createRunner split, per G's design

Round 3 progress

Round 3 complete: the createRunner split

Round 4: hook extraction in the big React components

Round 4 complete: hook extraction

Round 5

24 remaining items

Round 6

Done: every file on the original list is split

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Refactor passes: dead code, ThreadView split, shared Insights CSS, provider process helper #1447

Description

Findings

Passes

Not now

Activity

currentbits commented on Oct 4, 2026

currentbits commented on Oct 4, 2026

Round 2

currentbits commented on Oct 4, 2026

Round 3: the createRunner split, per G's design

currentbits commented on Oct 4, 2026

Round 3 progress

currentbits commented on Oct 5, 2026

Round 3 complete: the createRunner split

currentbits commented on Oct 5, 2026

Round 4: hook extraction in the big React components

currentbits commented on Oct 5, 2026

Round 4 complete: hook extraction

Round 5

24 remaining items

currentbits commented on Oct 5, 2026

Round 6

currentbits commented on Oct 5, 2026

currentbits commented on Oct 5, 2026

Done: every file on the original list is split

currentbits commented on Oct 5, 2026

currentbits commented on Oct 9, 2026

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions