Repository navigation
Fix MCP discovery, approvals, and provider skill selection - #1370
Merged
Merged
Conversation
Bind Claude Planboard configuration to its project and refresh warm sessions when managed MCP contents change. Route Codex MCP tool confirmations through permission cards. Page MCP issue listings while preserving the complete open board backlog, and select skill bodies by provider with visible instruction drift.
5 tasks
currentbits
marked this pull request as ready for review
September 28, 2026 06:40
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude could omit Planboard tools and keep using stale MCP connections; Codex rejected ordinary MCP tool confirmations as unsupported, preventing calls such as Girder tools. This binds Claude configuration to the project, replaces warm sessions when managed MCP contents change, and routes Codex confirmations through the existing permission card with correct allow/deny/cancel responses.
Planboard MCP reads now return bounded pages with state, cursor, and exact-number lookup. The board fetches all open issues separately from 100 recent closed issues. Slash commands select the active provider's skill or shared source, honor Codex/Cursor home overrides, and display differing installed instructions without overwriting variants.
Validation on macOS: 6,967 checks pass across all suites, with the complete Electron suite run at concurrency 4 after two unchanged startup-timeout fixtures failed under default full load. Typecheck and production build pass. A real Codex 0.157.1 model-initiated diagnostic tool call completed through the new approval mapping. Claude generated-config discovery and warm-process refresh have integration regressions; arbitrary elicitation forms remain outside this change (#1190).
Hosted macOS and Linux tests pass. Windows exposed two fixture races: Kimi overlay cleanup now reuses the existing bounded async rmTree helper, and the Codex steering test waits for the real client readiness signal instead of the fake server recording an inbound request. A delayed turn/start reply reproduced the steering failure before the correction. All 39 focused Kimi and 40 focused Codex checks pass; all six hosted checks pass at 1a19ebb (run 36387517093), including complete Windows, Linux, and macOS suites.
Tracks #1369, #1333, and the backend portion of #1187. This does not restart the Solenta app.