Skip to content

Initialize Browser pane before binding MCP preview tools - #1377

Merged
currentbits merged 2 commits into
mainfrom
fix/preview-initial-navigation
Sep 28, 2026
Merged

currentbits merged 2 commits into
mainfrom
fix/preview-initial-navigation

Conversation

@currentbits

@currentbits currentbits commented Sep 28, 2026 •

Copy link
Copy Markdown
Owner

Opening Views → Browser creates an empty webview without a src. Electron never creates its guest, so the pane never calls preview.bind and the MCP preview tool reports the open pane as closed. Both manual and automatic navigation depend on that missing binding.

Initialize the guest at about:blank. The existing empty state remains visible until a local URL loads, and the existing partition and navigation policy still apply.

The PR also uses the existing asynchronous rmTree helper in three Grok runner fixtures whose synchronous cleanup failed with Windows EBUSY. Environment variables are restored before awaiting removal. All pipe-close assertions remain enabled; production process handling is unchanged.

Validation:

  • An isolated Electron 35.7.5 probe reproduced the missing guest without src and received did-attach with a valid guest ID after setting about:blank.
  • The renderer regression failed before this change and passed afterward; all 12 focused renderer/host preview checks pass.
  • All 43 focused Grok checks pass with an isolated guardrails setting.
  • All six hosted macOS, Linux, and Windows source/smoke checks pass at 2974079: https://github.com/currentbits/solenta/actions/runs/36432136342. The Windows log confirms all three repaired Grok fixtures and the descendant-stdio assertion pass.

The input-card visual verification tracked in #1369 remains open until the repaired Browser pane is available in the running app.

@currentbits
currentbits marked this pull request as ready for review September 28, 2026 13:25
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-28T13:26:44.332416Z 06fbf41 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@currentbits
currentbits merged commit 22c8d44 into main Sep 28, 2026
6 checks passed
@currentbits
currentbits deleted the fix/preview-initial-navigation branch October 3, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant