Repository navigation
Initialize Browser pane before binding MCP preview tools - #1377
Merged
Merged
Conversation
currentbits
marked this pull request as ready for review
September 28, 2026 13:25
5 tasks
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening Views → Browser creates an empty webview without a
src. Electron never creates its guest, so the pane never callspreview.bindand the MCP preview tool reports the open pane as closed. Both manual and automatic navigation depend on that missing binding.Initialize the guest at
about:blank. The existing empty state remains visible until a local URL loads, and the existing partition and navigation policy still apply.The PR also uses the existing asynchronous
rmTreehelper in three Grok runner fixtures whose synchronous cleanup failed with WindowsEBUSY. Environment variables are restored before awaiting removal. All pipe-close assertions remain enabled; production process handling is unchanged.Validation:
srcand receiveddid-attachwith a valid guest ID after settingabout:blank.The input-card visual verification tracked in #1369 remains open until the repaired Browser pane is available in the running app.