Repository navigation
test(thread): poll instead of fixed sleeps in the tail-first tests - #1497
Merged
Merged
Conversation
…1475) The tail-first fill-in parses five large answers one idle slot at a time (setTimeout(0) under jsdom) and then mounts in a transition; a fixed 50 ms sleep lost that race on a loaded Ubuntu runner (seen on #1494's CI, an electron-only PR). Poll up to 5 s for the condition instead, same for the 120 ms stream-throttle wait in the sibling test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1489's "mounts a big thread's tail first" test failed on #1494's Ubuntu CI. #1494 is electron-only, so the failure isn't related to it.
Cause: the test waited a fixed 50 ms for the tail-first fill-in. That fill-in parses five large answers one idle slot at a time (
setTimeout(0)under jsdom) and then mounts in a transition, which can outrun 50 ms on a loaded runner.Fix: poll for the condition every 50 ms for up to 5 s. The sibling test's 120 ms stream-throttle sleep gets the same treatment. Test-only change; all 7 window tests pass locally.
🤖 Generated with Claude Code