Repository navigation
test(electron): provider-switch-context reads only complete log lines - #1517
Merged
Merged
Conversation
readPrompts JSON-parsed every line of a log the fake agent was still appending to; waitFor polls it, so under full-suite load a half-written last line threw and failed the test (seen on three verification runs). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
provider-switch-context.test.js(from #1494) failed intermittently under full-suite load: it failed on three separate verification runs and passed alone.Cause:
readPromptsJSON-parsed every line of a JSONL log that the fake agent subprocess was still appending to.waitForpollsreadPrompts, so a half-written last line threwSyntaxErrorinside the predicate.Fix: parse only newline-terminated lines (
split("\n").slice(0, -1)). Each record is oneJSON.stringify'd string plus\n, so the dropped tail is either empty or partial. The test passes 10 of 10 alone; test-only change.🤖 Generated with Claude Code