Repository navigation
Resize Changes and PR file columns without losing narrow layouts - #1949
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
3 tasks
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 45473d4085
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long filenames were constrained by the fixed Changes file column, while PR Code always stacked its file list above the diff.
Add a shared file/diff layout that supports bounded drag and keyboard resizing, reset and remembered width. It reserves space for the diff and switches to a stacked layout when the pane or window is narrow. File selection/navigation remain in their existing components; pointer cancellation, hidden-separator focus and stored-width validation are covered.
Validation: 71 focused renderer tests, typecheck and preload consistency pass. A real Chromium fixture verified drag, narrow stacking, width restoration, reload persistence, invalid storage and no page errors; wide/narrow screenshots were inspected. Independent review found no material issues and repeated the four layout tests. Packaged Electron and other browser engines were not exercised.
Integration note: pending PR #1924 also changes the former .changesSplit responsive CSS. This change moves that layout into scoped FileDiffLayout styles; reconcile that small overlap when the other PR lands.
Closes #1929. Part of #1926.
Created with GPT-6.1 Sol in Codex, including GPT-6.1 Sol implementation and review workers.