Skip to content

Keep review paths and actions consistent for subfolder projects - #1953

Merged
currentbits merged 4 commits into
mainfrom
fix/git-diff-repository-paths
Nov 8, 2026
Merged

currentbits merged 4 commits into
mainfrom
fix/git-diff-repository-paths

Conversation

@currentbits

@currentbits currentbits commented Nov 8, 2026 •

Copy link
Copy Markdown
Owner

Reviewing a project opened below its repository root could misidentify files when Git's diff.relative setting was enabled. Changes, checkpoints, image review, commit and revert now use consistent repository-relative identities, including untracked files and symlinked project paths. Literal path handling prevents wildcard filenames from selecting sibling files.

Validation: 54 focused diff/commit/image tests, 18 scope/turn/IPC tests and 34 isolated Git/WSL transport tests passed; typecheck/preload synchronization passed. Sixteen added mutation/image regressions failed against the original implementation and pass with the repair. Tests cover subfolder collisions, partial commits preserving staged siblings and cache invalidation.

Closes #1942. Part of #1926.

Built and reviewed with GPT-6.1 Sol in Codex.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-08T12:45:11.619620Z b35d490 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@currentbits currentbits changed the title Keep review diffs consistent for subfolder projects Keep review paths and actions consistent for subfolder projects Nov 8, 2026
@currentbits
currentbits merged commit ec1cb29 into main Nov 8, 2026
14 checks passed
@currentbits
currentbits deleted the fix/git-diff-repository-paths branch November 8, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keep internal Git diff paths stable with user display settings

1 participant