Conversation
|
Is there any reason not to merge it? This allows d3 to work on applications that use CSP without |
curran
left a comment
There was a problem hiding this comment.
It would be great to make sure the new code is covered by tests.
|
I've added a test and fixed the formatting. |
|
Just curious, how much slower is this? |
|
Hey, any update on this? It would be really helpful for us as it would allow us to apply proper CSP while still using this library. |
|
Hey @vrana , would you be interested to reconcile this branch with the latest I opened a very similar PR but it looks like you had this solution first, it would be great to revisit. The Function approach is great in environments that support it, but in environments that don't, a slower solution is better than a "page is blank" one. |
Using
parseRowswith CSP enabled is quite cumbersome. I don't see a reason why this shouldn't just work (even though a little slower).