Fix number_to_human rounding and skipping errors#11
Merged
Conversation
danielberkompas
force-pushed
the
fix-rounding-errors
branch
from
7e25c76 to
9b430cf
Compare
danielberkompas
added a commit
that referenced
this pull request
Dec 16, 2015
Fix number_to_human rounding and skipping errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in #10,
number_to_humandoes not properly handle numberssuch as 999,001 or 999,999, and it also incorrectly rounds 998.99 to
998.00.
This commit fixes both issues. Contrary to what the bug report
suggested, 998.999 should round to 999.00 with a precision of 2, not
998.99.
Closes #10.