Skip to content

fix #83 - Bug where rating data was not being copied to the view.#84

Open
oboyle wants to merge 1 commit intodanielgtaylor:masterfrom
oboyle:respect-brew-rating-data
Open

fix #83 - Bug where rating data was not being copied to the view.#84
oboyle wants to merge 1 commit intodanielgtaylor:masterfrom
oboyle:respect-brew-rating-data

Conversation

@oboyle
Copy link

@oboyle oboyle commented Sep 1, 2014

There was a static value (4) where the value read from the form
should have been. This is fixed.

This change can be tested by performing the following actions.

  • Click the Brew button to add a new brew.
  • Select 1 for the rating, click Save.
  • Recipe view should show the rating as 1.
  • Click Edit, this view should show the rating as 1.
  • Change the rating to 5. Click Save.
  • Recipe view should show the rating as 5.
  • Click Edit, this view should show the rating as 5.

I was not able to successfully get the Coffeescript tests to pass. I think this is due to me having a new version of Coffeescript and the test being written to an older version.

…the view.

There was a static value (4) where the value read from the form
should have been. This is fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant