Skip to content

fixed #11917 (Default to native platform in Windows builds) #5428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danmar merged 2 commits into from
Sep 11, 2023
Merged

fixed #11917 (Default to native platform in Windows builds) #5428

danmar merged 2 commits into from
Sep 11, 2023

Conversation

@firewave
Copy link
Collaborator

@firewave firewave commented Sep 10, 2023

No description provided.

@danmar danmar merged commit 64cd09a into danmar:main Sep 11, 2023
@firewave firewave deleted the native branch September 11, 2023 11:00
@chrchr-github
Copy link
Collaborator

chrchr-github commented Sep 18, 2023 •
edited
Loading

What is the native platform supposed to represent? We have simplifyMicrosoftStringFunctions(), which does not run for native.
Edit: We should probably adjust isWindows().

@danmar
Copy link
Owner

danmar commented Sep 18, 2023

The native was meant to match the compiler that built the cppcheck binary. So.. the sizes determined at compile time.

@chrchr-github chrchr-github mentioned this pull request Sep 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@firewave @chrchr-github @danmar