Skip to content

Partial fix for #14523 FN knownConditionTrueFalse (brace-init in if, regression) #8330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrchr-github merged 2 commits into from
Mar 15, 2026
+6 −1
Merged

Partial fix for #14523 FN knownConditionTrueFalse (brace-init in if, regression) #8330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21b6a41
Update testvalueflow.cpp
chrchr-github Mar 12, 2026
864e2eb
Update vf_common.cpp
chrchr-github Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/vf_common.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ namespace ValueFlow
if (!tok->isTemplateArg())
value.setKnown();
setTokenValue(tok->next(), std::move(value), settings);
} else if (Token::simpleMatch(tok, "= { } ;")) {
} else if (Token::simpleMatch(tok, "= { }")) {
const Token* lhs = tok->astOperand1();
if (lhs && lhs->valueType() && (lhs->valueType()->isIntegral() || lhs->valueType()->pointer > 0)) {
Value value(0);
Expand Down
5 changes: 5 additions & 0 deletions test/testvalueflow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6451,6 +6451,11 @@ class TestValueFlow : public TestFixture {
" return x;\n"
"}\n";
ASSERT_EQUALS(true, testValueOfXKnown(code, 5U, 0));

code = "void f() {\n"
" if (int* x = {}) {}\n"
"}\n";
ASSERT_EQUALS(true, testKnownValueOfTok(code, "=", 0));
}

static std::string isPossibleContainerSizeValue(std::list<ValueFlow::Value> values,
Expand Down
Loading