Add function log_indices that returns number of currently active indices#194
Merged
daroczig merged 5 commits intodaroczig:masterfrom Aug 13, 2024
WurmPeter:master
Merged
Add function log_indices that returns number of currently active indices#194daroczig merged 5 commits intodaroczig:masterfrom WurmPeter:master
daroczig merged 5 commits intodaroczig:masterfrom
WurmPeter:master
Conversation
daroczig
reviewed
Aug 12, 2024
daroczig
reviewed
Aug 12, 2024
Owner
|
Thanks a ton 🙌 I've left a few minor comments -- would you mind reviewing those, and also run roxygen to generate the |
Contributor
Author
|
I have made a new commit. Please review again :) |
Owner
|
Thank you! Could you please double check on #194 (comment)? I don't think any colons are needed at all. |
Contributor
Author
|
Sorry to cause so many problems... Should I commit the changed NAMESPACE file? |
Owner
|
no worries 🙌 |
Owner
|
thank you very much 🙇 |
Contributor
Author
|
Great, thanks for your patience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solving #180
One of my very first pull requests. Please feel free to tell me anything I could do better.