Skip to content

Comments

Add function log_indices that returns number of currently active indices#194

Merged
daroczig merged 5 commits intodaroczig:masterfrom
WurmPeter:master
Aug 13, 2024
Merged

Add function log_indices that returns number of currently active indices#194
daroczig merged 5 commits intodaroczig:masterfrom
WurmPeter:master

Conversation

@WurmPeter
Copy link
Contributor

Solving #180

One of my very first pull requests. Please feel free to tell me anything I could do better.

@daroczig
Copy link
Owner

Thanks a ton 🙌

I've left a few minor comments -- would you mind reviewing those, and also run roxygen to generate the Rd files? No worries if that's too much, I can also do that, just let me know.

@WurmPeter
Copy link
Contributor Author

I have made a new commit. Please review again :)

@daroczig
Copy link
Owner

Thank you! Could you please double check on #194 (comment)? I don't think any colons are needed at all.

@WurmPeter
Copy link
Contributor Author

Sorry to cause so many problems... Should I commit the changed NAMESPACE file?

@daroczig
Copy link
Owner

no worries 🙌
yes, pls. would be also nice to update the pkgdown.yaml file as per the related error msg (mention among the other related fans)

@daroczig daroczig merged commit 006a3ad into daroczig:master Aug 13, 2024
@daroczig
Copy link
Owner

thank you very much 🙇

@WurmPeter
Copy link
Contributor Author

Great, thanks for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants