FIX #62280 Parser and analyzer AST should be updated to reject augmented enum values#62941
Open
Darkildo wants to merge 1 commit intodart-lang:mainfrom
Conversation
|
Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at: https://dart-review.googlesource.com/c/sdk/+/489521 Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aligns the parser and analyzer with
dart-lang/language@ebd9e18, which removed support for augmenting enum values.It changes the parser so code like:
is no longer accepted as a valid augmented enum constant declaration. Instead, the parser reports the leading augment as an extraneous modifier and recovers on the enum value name.
On the analyzer side, this PR also removes the internal use of enum-value augmentation data and deprecates EnumConstantDeclaration.augmentKeyword. That getter is part of the public analyzer API and is not experimental, so deprecating it now preserves semantic versioning and makes its future removal explicit.
The PR also updates parser and summary tests to reflect the new behavior.
Fix #62280