Skip to content

fix(drive)!: cumulative fees are not reset between blocks#474

Merged
shumkov merged 3 commits into
v0.23-devfrom
fix-cumulative-fees
Aug 8, 2022
Merged

fix(drive)!: cumulative fees are not reset between blocks#474
shumkov merged 3 commits into
v0.23-devfrom
fix-cumulative-fees

Conversation

@shumkov
Copy link
Copy Markdown
Collaborator

@shumkov shumkov commented Aug 8, 2022

Issue being fixed or feature implemented

Cumulative fees for block should be reset on the next begin block but it's not.

What was done?

  • Reset storage and processing cumulative fees in block execution context

How Has This Been Tested?

Unit tests

Breaking Changes

Correct cumulative fees invalidate previous blockchain data

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v0.23.0 milestone Aug 8, 2022
@shumkov shumkov marked this pull request as ready for review August 8, 2022 16:44
@shumkov shumkov requested a review from antouhou as a code owner August 8, 2022 16:44
@shumkov shumkov merged commit 6b02b26 into v0.23-dev Aug 8, 2022
@shumkov shumkov deleted the fix-cumulative-fees branch August 8, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants