Update docstrings to import dask.ml#871
Open
jacobtomlinson wants to merge 2 commits intodask:mainfrom
Open
Conversation
jrbourbeau
reviewed
Nov 1, 2021
Member
jrbourbeau
left a comment
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @jacobtomlinson. We'll need to wait for a dask release which includes dask/dask#6384. Additionally, this will require us to bump the minimum supported version of dask
Member
|
@jacobtomlinson @jrbourbeau Are we to a point where this can be merged? |
Member
|
Yes, since dask/dask#6384 was included in the Line 14 in 1e811ce |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that dask/dask#6384 is in updated user examples to import from
dask.mlinstead ofdask_ml.xref #687