Skip to content

ci: align breaking-change detector with release-it parser semantics #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarioCadenas merged 1 commit into from
May 6, 2026
+9 −4
Merged

ci: align breaking-change detector with release-it parser semantics #353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions tools/detect-breaking-commits.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,16 @@ const TRACKED_PATHS = [
"packages/shared",
];

// Conventional Commits breaking-change markers:
// 1. `type!:` or `type(scope)!:` in the subject line
// 2. `BREAKING CHANGE:` or `BREAKING-CHANGE:` footer line
// Matches what `conventional-changelog-conventionalcommits` (used by
// release-it) treats as a major-bumping breaking change. Verified against
// the live parser; covers:
// - Subject `type!:` / `type(scope)!:` (case-insensitive)
// - Footer line `BREAKING CHANGE` or `BREAKING-CHANGE`, with optional
// leading whitespace, optional colon, case-insensitive
// Excludes the plural `BREAKING CHANGES` (parser does NOT treat it as
// breaking — `\b(?!S)` enforces this) and mid-line / list-item occurrences.
const BREAKING_PATTERN =
/^(feat|fix|chore|refactor|perf|build|ci|docs|style|test|revert)(\([^)]+\))?!:|^BREAKING[ -]CHANGE:/m;
/^(feat|fix|chore|refactor|perf|build|ci|docs|style|test|revert)(\([^)]+\))?!:|^\s*BREAKING[ -]CHANGE\b(?!S)/im;

function requireEnv(name: string): string {
const value = process.env[name];
Expand Down
Loading