acc: fix volumes/recreate output after JSON formatter change#5245
Merged
Conversation
Since #5170 the CLI's JSON output uses the standard `: ` separator (via `json.MarshalIndent`) rather than the compact `":"` form produced by the previous `nwidger/jsoncolor` dependency. The acceptance output for `bundle/resources/volumes/recreate` still captured the compact form for one `grants get` line and has been failing on UCWS nightlies since #5170 merged. #5227 picked up the same staleness in `TestClustersGet`; this picks up the missed acceptance output. Co-authored-by: Isaac
denik
approved these changes
May 13, 2026
andrewnester
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #5170 the CLI's JSON output uses the standard
:separator (viajson.MarshalIndent) rather than the compact":"form produced by the previousnwidger/jsoncolordependency. The acceptance output forbundle/resources/volumes/recreatestill captured the compact form for onegrants getline and has been failing on UCWS nightlies since #5170 merged. #5227 picked up the same staleness inTestClustersGet; this picks up the missed acceptance output.This pull request and its description were written by Isaac.