Skip to content

Make StreamingChunkProvider the default chunk provider #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jayantsing-db wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make StreamingChunkProvider the default chunk provider #1173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/com/databricks/jdbc/common/DatabricksJdbcUrlParams.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,8 +190,8 @@ public enum DatabricksJdbcUrlParams {
"EnableTokenFederation", "Enable token federation for authentication", "1"),
ENABLE_STREAMING_CHUNK_PROVIDER(
"EnableStreamingChunkProvider",
"Enable streaming chunk provider for result fetching (experimental)",
"0"),
"Enable streaming chunk provider for result fetching",
"1"),
LINK_PREFETCH_WINDOW(
"LinkPrefetchWindow",
"Number of chunk links to prefetch ahead of consumption. "
Expand Down
10 changes: 5 additions & 5 deletions src/test/java/com/databricks/jdbc/api/impl/arrow/ArrowStreamResultTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,15 +478,14 @@ public void testNullComplexTypeWithComplexDatatypeSupportDisabled() throws Excep

@Test
public void testStreamingChunkProviderEnabledForSeaResult() throws Exception {
// Enable StreamingChunkProvider via connection property
// StreamingChunkProvider is enabled by default
Properties props = new Properties();
props.setProperty("EnableStreamingChunkProvider", "1");
IDatabricksConnectionContext connectionContext =
DatabricksConnectionContextFactory.create(JDBC_URL, props);

assertTrue(
connectionContext.isStreamingChunkProviderEnabled(),
"StreamingChunkProvider should be enabled via property");
"StreamingChunkProvider should be enabled by default");

DatabricksSession localSession = new DatabricksSession(connectionContext, mockedSdkClient);

Expand Down Expand Up @@ -518,14 +517,15 @@ public void testStreamingChunkProviderEnabledForSeaResult() throws Exception {

@Test
public void testStreamingChunkProviderDisabledUsesRemoteChunkProvider() throws Exception {
// Default properties - StreamingChunkProvider disabled
// Explicitly disable StreamingChunkProvider to use RemoteChunkProvider
Properties props = new Properties();
props.setProperty("EnableStreamingChunkProvider", "0");
IDatabricksConnectionContext connectionContext =
DatabricksConnectionContextFactory.create(JDBC_URL, props);

assertFalse(
connectionContext.isStreamingChunkProviderEnabled(),
"StreamingChunkProvider should be disabled by default");
"StreamingChunkProvider should be disabled when explicitly set to 0");

DatabricksSession localSession = new DatabricksSession(connectionContext, mockedSdkClient);

Expand Down
Loading