Conversation
I couldn't add supported python versions. Poetry doesn't provide the correct trove classifiers based on our current Python specification. If this is important we can add it later.
moderakh
approved these changes
Jun 27, 2022
Collaborator
moderakh
left a comment
moderakh
left a comment
There was a problem hiding this comment.
LGTM.
I added two comments but they are not blocking comments. Please feel free to merge the PR. and look at those later.
CONTRIBUTING.md
Outdated
| #### Specific tests | ||
|
|
||
| ```bash | ||
| poetry run pytest tests/path/to/test.py |
Collaborator
There was a problem hiding this comment.
how can I run a specific test method from a test file? does poetry support that?
(non blocking comment)
Contributor
Author
There was a problem hiding this comment.
Good catch. I added a more specific example in 22bbd22
moderakh
reviewed
Jun 27, 2022
saishreeeee
pushed a commit
that referenced
this pull request
Jun 4, 2025
* Add license and contributing sections to README. * Add environment setup docs to CONTRIBUTING * Clarify example of connection details in example * Add badges from pypi * Explicitly call out Python 3.7 or above is needed
saishreeeee
pushed a commit
that referenced
this pull request
Jun 4, 2025
* Add license and contributing sections to README. * Add environment setup docs to CONTRIBUTING * Clarify example of connection details in example * Add badges from pypi * Explicitly call out Python 3.7 or above is needed Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description