Fix cancellation.#173
Merged
Merged
Conversation
zhengruifeng
approved these changes
Sep 19, 2022
allisonwang-db
approved these changes
Sep 19, 2022
Collaborator
allisonwang-db
left a comment
allisonwang-db
left a comment
There was a problem hiding this comment.
Thanks for adding the integration test!
Contributor
Author
|
Thanks! merging, and backport to 1.2 and 1.1. |
ueshin
added a commit
that referenced
this pull request
Sep 19, 2022
### Description `DatabricksSQLConnectionWrapper` should have `cancel` method and handle it properly. Otherwise, the following error will be seen when cancelling the session due to e.g., `dbt test --fail-fast`: ``` AttributeError: 'DatabricksSQLConnectionWrapper' object has no attribute 'cancel' ```
ueshin
added a commit
that referenced
this pull request
Sep 19, 2022
### Description `DatabricksSQLConnectionWrapper` should have `cancel` method and handle it properly. Otherwise, the following error will be seen when cancelling the session due to e.g., `dbt test --fail-fast`: ``` AttributeError: 'DatabricksSQLConnectionWrapper' object has no attribute 'cancel' ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DatabricksSQLConnectionWrappershould havecancelmethod and handle it properly.Otherwise, the following error will be seen when cancelling the session due to e.g.,
dbt test --fail-fast: