Partially revert to fix the case where schema config contains uppercase letters.#224
Merged
Conversation
allisonwang-db
approved these changes
Nov 4, 2022
| f"got {len(row)} values, expected 4" | ||
| ) | ||
| _, name, _, information = row | ||
| _schema, name, _, information = row |
Collaborator
There was a problem hiding this comment.
Can we comment here on why we need the schema returned from the row?
Contributor
Author
There was a problem hiding this comment.
Sure, left a comment.
Actually we might have a better way to handle this, but let me just revert to avoid the current regression.
Contributor
Author
|
Thanks! merging. |
ueshin
added a commit
that referenced
this pull request
Nov 4, 2022
…se letters. (#224) ### Description Partially reverts #221 to fix the case where `schema` config contains uppercase letters. ``` Compilation Error in model test (models/test.sql) When searching for a relation, dbt found an approximate match. Instead of guessing which relation to use, dbt will move on. Please delete DBT_TEST.test, or rename it to be less ambiguous. Searched for: dbt_test.test Found: DBT_TEST.test > in macro load_cached_relation (macros/adapters/relation.sql) > called by macro load_relation (macros/adapters/relation.sql) > called by macro materialization_incremental_databricks (macros/materializations/incremental/incremental.sql) > called by model test (models/test.sql) ```
ueshin
added a commit
that referenced
this pull request
Nov 4, 2022
…se letters. (#224) ### Description Partially reverts #221 to fix the case where `schema` config contains uppercase letters. ``` Compilation Error in model test (models/test.sql) When searching for a relation, dbt found an approximate match. Instead of guessing which relation to use, dbt will move on. Please delete DBT_TEST.test, or rename it to be less ambiguous. Searched for: dbt_test.test Found: DBT_TEST.test > in macro load_cached_relation (macros/adapters/relation.sql) > called by macro load_relation (macros/adapters/relation.sql) > called by macro materialization_incremental_databricks (macros/materializations/incremental/incremental.sql) > called by model test (models/test.sql) ```
ueshin
added a commit
that referenced
this pull request
Nov 4, 2022
…se letters. (#224) ### Description Partially reverts #221 to fix the case where `schema` config contains uppercase letters. ``` Compilation Error in model test (models/test.sql) When searching for a relation, dbt found an approximate match. Instead of guessing which relation to use, dbt will move on. Please delete DBT_TEST.test, or rename it to be less ambiguous. Searched for: dbt_test.test Found: DBT_TEST.test > in macro load_cached_relation (macros/adapters/relation.sql) > called by macro load_relation (macros/adapters/relation.sql) > called by macro materialization_incremental_databricks (macros/materializations/incremental/incremental.sql) > called by model test (models/test.sql) ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Partially reverts #221 to fix the case where
schemaconfig contains uppercase letters.