Add optional argument for glob pattern in databricks COPY INTO#259
Merged
ueshin merged 2 commits intoJan 25, 2023
Merged
Conversation
dluftspring
changed the title
andrefurlan-db
approved these changes
Jan 25, 2023
allisonwang-db
approved these changes
Jan 25, 2023
Collaborator
allisonwang-db
left a comment
allisonwang-db
left a comment
There was a problem hiding this comment.
Thanks for adding this!
Contributor
|
Hi @dluftspring, could you add an item in CHANGELOG? I'll backport this to 1.4, so the item would be under the section for 1.4.0. Thanks. |
ueshin
approved these changes
Jan 25, 2023
Contributor
|
The linter failure is not related to this PR. Let's fix it later. |
Contributor
|
Thanks! merging. |
ueshin
pushed a commit
that referenced
this pull request
Jan 25, 2023
### Description This PR adds an optional key word argument to the `databricks_copy_into` macro that allows the user to specify a pattern for file globbing. Please let me know if there are unintended consequences i'm not considering but based on my reading of the docs this should work. Please let me know how you normally handle unit testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an optional key word argument to the
databricks_copy_intomacro that allows the user to specify a pattern for file globbing. Please let me know if there are unintended consequences i'm not considering but based on my reading of the docs this should work. Please let me know how you normally handle unit testing.Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.