[feat] OAuth support (#307)#327
Merged
Merged
Conversation
* oauth support --------- Signed-off-by: Andre Furlan <andre.furlan@databricks.com>
rcypher-databricks
previously approved these changes
May 1, 2023
Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
d435c1c
andrefurlan-db
added a commit
that referenced
this pull request
May 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for OAuth: both 3-legged and 2-legged.
From a user perspective,
tokenis not mandatory anymore. OAuth with SSO (browser login) will be used ifauth_type: oauthis defined.For automation and CI/CD use cases,
client_idandclient_secretare now available as config.Usage
AWS
It just works as long as admin has enabled
databricks-dbt-adapteras an OAuth application:Profile:
Azure
A Public client/ Native Azure AD Application must be created with redirect URL
http://localhost:8020. For SSO, Azure Application (client) ID must be used forclient_id.Profile:
GCP
GCP is not supported at the moment.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.