Python: if the cluster is already starting up, just wait for it#461
Merged
Conversation
benc-db
requested review from
andrefurlan-db,
rcypher-databricks and
susodapop
as code owners
susodapop
previously approved these changes
Sep 25, 2023
susodapop
left a comment
susodapop
left a comment
There was a problem hiding this comment.
LGTM. This is just wrapping existing code so we can call it from a different place, yes?
rcypher-databricks
previously approved these changes
Sep 25, 2023
Collaborator
Author
It also changes the behavior if the cluster is already starting. If the cluster was already starting, we would get those pending exceptions. Now if the state isn't terminated or terminating, it waits until the state is running. This is important when running with multiple threads because one will start the cluster, then the next will see that its not terminated, so attempt to submit the job. |
benc-db
dismissed stale reviews from rcypher-databricks and susodapop
via
31cdaaa
benc-db
force-pushed
the
make_waiting_better
branch
from
07bc2a6 to
31cdaaa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This should fix the issue where multiple threads try to start the same cluster, and we get an exception saying the cluster is Pending.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.