Address sql injection duckdb#2278
Open
sundarshankar89 wants to merge 8 commits intofeature/typed-table-schemasfrom
Open
Address sql injection duckdb#2278sundarshankar89 wants to merge 8 commits intofeature/typed-table-schemasfrom
sundarshankar89 wants to merge 8 commits intofeature/typed-table-schemasfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/typed-table-schemas #2278 +/- ##
===============================================================
+ Coverage 64.05% 64.15% +0.09%
===============================================================
Files 99 99
Lines 8859 8880 +21
Branches 920 925 +5
===============================================================
+ Hits 5675 5697 +22
+ Misses 3009 3008 -1
Partials 175 175 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✅ 133/133 passed, 7 flaky, 5 skipped, 10m28s total Flaky tests:
Running from acceptance #3688 |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds SQL injection protection for DuckDB table name.
Made design choice by limiting the name pattern in pipline config since this only expected to be used for information schema extracts.
Resolves #..
Functionality
databricks labs lakebridge ...Tests