Skip to content

Fix raster docs based on Python docstrings#377

Open
mihaigurau-tomtom wants to merge 1 commit intodatabrickslabs:mainfrom
mihaigurau-tomtom:fix-raster-docs
Open

Fix raster docs based on Python docstrings#377
mihaigurau-tomtom wants to merge 1 commit intodatabrickslabs:mainfrom
mihaigurau-tomtom:fix-raster-docs

Conversation

@mihaigurau-tomtom
Copy link
Copy Markdown

Just a few small edits of the docs for Raster Functions, particularly regarding descriptions of returns for rst_rastertogridcount and rst_rastertogridmin.

I think it'd be nice to update the images for the rst_rastertogrid* functions as well, as they seem to be inconsistent & now all link to the output of rst_rastertogridavg. However, I couldn't generate the images myself, hence that change may be part of a different PR.

Cheers! :)

@milos-colic
Copy link
Copy Markdown
Contributor

@mihaigurau-tomtom We have now opened up the process for merging the external PRs.
Can you please confirm with the: https://github.com/databrickslabs/mosaic/blob/main/CONTRIBUTING.md?
After your PR is compliant, I am happy to review it and merge it if the review is successful.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 31, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.99%. Comparing base (bb49756) to head (1ef9e02).
⚠️ Report is 1003 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #377   +/-   ##
=======================================
  Coverage   94.99%   94.99%           
=======================================
  Files         198      198           
  Lines        5655     5655           
  Branches      181      181           
=======================================
  Hits         5372     5372           
  Misses        283      283           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@edurdevic
Copy link
Copy Markdown
Contributor

Hi @mihaigurau-tomtom , in order for us to proceed it is sufficient to add a comment to this PR with your sign-off (Eg. Signed-off-by: Joe Smith <joe.smith@email.com>).
We need this to make sure you are aware of the current license, and that you agree with open sourcing it. :)

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants