Open
Conversation
Fix for PDB files that have IMGT numbering. The original code ends up adding/removing residues when it runs into a residue number of "112A" or "34A". To fix, I just renumber the residues whenever the label changes. So they'll be just 1 to N residues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for PDB files that have IMGT numbering. Issue #92
The original code ends up adding/removing residues when it runs into a residue number of "112A" or "34A".
To fix, I just renumber the residues whenever the label changes. So they'll be just 1 to N residues.
It would be better if we first run the PDB file through some tools that fixes the PDB and renumbers it with only integer values. However, I didn't want to change too much of the code just in case other things might break.