-
Notifications
You must be signed in to change notification settings - Fork 52
Add coderabbit configuration #1270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+35
−2
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| language: en-GB | ||
| reviews: | ||
| path_instructions: | ||
| - path: "newsfragments/*.rst" | ||
| instructions: | | ||
| Validate newsfragment files: | ||
| 1. Read valid types from [tool.towncrier.fragment] in pyproject.toml | ||
| 2. Filename must follow the pattern: [number].[type].rst OR +[hash].[type].rst where: | ||
| - [number] is an issue number or PR number | ||
| - [type] must be one of the types defined in towncrier configuration | ||
| 3. Content must be a clear, concise description of the change | ||
| 4. Content should be suitable for inclusion in CHANGES.rst | ||
| 5. Verify the type matches the nature of the change based on towncrier type definitions | ||
| 6. Flag any files with invalid types or malformed filenames | ||
| 7. Check that the description is meaningful (not just "fix" or "update") | ||
|
|
||
| pre_merge_checks: | ||
| custom_checks: | ||
| - name: "Newsfragment Check" | ||
| mode: "warning" | ||
| instructions: | | ||
| Check if a newsfragment file has been added to the newsfragments/ directory. | ||
| Read the towncrier configuration from pyproject.toml to determine valid newsfragment types. | ||
| If no newsfragment is present, suggest which type should be added based on the PR changes. | ||
| Suggest the filename format: [issue_or_pr_number].[type].rst | ||
| Remind contributors to use: `pipenv run towncrier create [number].[type].rst` | ||
| Skip the check if the PR only updates existing newsfragments or is a trivial change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Add coderabbitai configuration with instructions to keep an eye for newsfragments. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Fixes for diagram workflow. | ||
fizyk marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.