Skip to content
This repository was archived by the owner on Apr 8, 2025. It is now read-only.

Add optional s3 auth via params#511

Merged
tholor merged 1 commit intomasterfrom
optional_s3_auth
Sep 2, 2020
Merged

Add optional s3 auth via params#511
tholor merged 1 commit intomasterfrom
optional_s3_auth

Conversation

@tholor
Copy link
Member

@tholor tholor commented Sep 2, 2020

Adding another option to do authentication in download_from_s3()

The default and recommended authentication follows boto3's trajectory of checking for ENV variables, .aws/credentials etc. (see https://boto3.amazonaws.com/v1/documentation/api/latest/guide/credentials.html).

With this PR, there's also the option to pass access_key, secret_access_key and region_name directly as this is needed in some enterprise environments with local s3 deployments.

@tholor tholor requested a review from tanaysoni September 2, 2020 09:51
@tholor tholor merged commit dc4af09 into master Sep 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants