Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
anakin87
reviewed
Jan 29, 2025
| @@ -6,15 +6,13 @@ | |||
| "id": "HJsHqaTksDHt" | |||
Member
There was a problem hiding this comment.
If so, you need to call the corresponding tool with the provided arguments and send the tool response back to OpenAI
This step is only needed if you want the LM to rephrase the tool call result.
Reply via ReviewNB
Contributor
Author
There was a problem hiding this comment.
Yes I agree but it's usually the case. e.g the tool call result coming from the weather tool is
{"weather": "sunny", "temperature": 21.8, "unit": "fahrenheit"}
anakin87
approved these changes
Jan 29, 2025
Member
anakin87
left a comment
anakin87
left a comment
There was a problem hiding this comment.
Looks very good in general.
Please take into account the comment above and maybe also mention somewhere that the unified Tool abstraction allows using function calling/tool calling in the same way with several others Chat Generators in Haystack (all Chat Generators in future).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #379