[MohammadHijjawi97]

Related Issues

No existing issue. This PR includes a regression test for the crash.

Proposed Changes:

DocumentTypeRouter passed mime_type metadata to re.fullmatch. A list or integer value raised TypeError. Treat non-string MIME metadata as missing and route those documents to unclassified. Also guard invalid file_path values when guessing MIME type: a non-empty value that is not a str/PathLike (e.g. a list of paths or an int) made Path(file_path) raise TypeError.

How did you test it?

• Unit test for list, integer and None mime_type metadata next to a valid string.
• Unit test for file_path metadata set to a list and an int next to a valid path: the valid one goes to text/plain, the others to unclassified. It fails without the guard (TypeError: expected str, bytes or os.PathLike object, not list).
• test/components/routers/test_document_type_router.py: 23 passed; the router module is at 100% line coverage. ruff check / ruff format --check clean.

Notes for the reviewer

The ValueError in except (TypeError, ValueError) covers Python 3.13+, where mimetypes.guess_type parses the path as a URL and raises for paths such as //[draft/notes.txt ("Invalid IPv6 URL"). It is not tested because the behaviour differs by Python version.

Checklist

• I have read the contributors guidelines and the code of conduct.
• I have updated the related issue with new insights and changes.
• I have added unit tests and updated the docstrings.
• I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
• I have documented my code.
• I have added a release note file, following the contributors guidelines.
• I have run pre-commit hooks and fixed any issue.

[vercel]

@MohammadHijjawi97 is attempting to deploy a commit to the deepset Team on Vercel.

A member of the Team first needs to authorize it.

[github-actions]

Hi @MohammadHijjawi97, thanks for your interest in contributing to Haystack! 🙏

⚠️ You currently have 5 open pull requests in this repository (#12794, #12792, #12791, #12790 and this one). Our review capacity is limited, so please hold off opening more PRs until we've had a chance to review your first 2 open PRs. This helps us give each contribution the attention it deserves. Thank you!

This is an automated message to help us keep the review queue healthy.

[HaystackBot]

Hi @MohammadHijjawi97, thanks a lot for your contribution! 🙏

We noticed that the Contributor License Agreement (CLA) check (license/cla) hasn't passed yet, so we've temporarily moved this PR to draft and paused the review assignment.

To get your PR reviewed, please sign the CLA via the link in the license/cla check below (or in the CLA bot comment). As soon as the check turns green, this PR will automatically be marked ready for review again and a reviewer will be re-assigned.

[HaystackBot]

Thanks for signing the CLA, @MohammadHijjawi97! 🎉 This PR is now ready for review again and the reviewer has been re-assigned.

[MohammadHijjawi97]

CLA is signed now. This is ready for review whenever you have time.

[github-actions]

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
haystack/components/routers
document_type_router.py
Project Total

This report was generated by python-coverage-comment-action

[MohammadHijjawi97]

Hi @julian-risch, a short summary since you're assigned: I added a test for the file_path branch the coverage report flagged (a list or int file_path used to raise TypeError from Path(...); those documents now go to unclassified), so the router module is at 100% line coverage, and I just merged current main into the branch. The description has the before/after for both the mime_type and file_path cases. Happy to adjust anything.

[julian-risch]

Hi @MohammadHijjawi97 I am not aware of any Haystack component that writes a list or int into mime_type or file_path. So this guards against metadata shapes no Haystack component outputs and no user has reported this as an issue so far. It seems to hide malformed input too. Therefore, I'll close this PR.