fix: ensure ambient mode is the default in all operator code (#2326) (backport-0.60)#2327
Merged
slaskawi merged 1 commit intorelease/0.60from Jan 29, 2026
Conversation
## Description Updates operator code to ensure Ambient mode is set as the default mode in all places checking `pkg.spec.network.serviceMesh.mode`. ## Related Issue Known issues in 0.60.0 ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md) followed (cherry picked from commit bda5384)
mjnagel
approved these changes
Jan 29, 2026
slaskawi
deleted the
backport/bda5384adce387707b43a0af3bc294e9f0b87894-to-0.60
branch
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures ambient mode is the default for all operator code by adding fallback logic throughout the codebase. This is a backport from the main branch to the 0.60 release branch.
Changes:
- Modified operator controller code to default
serviceMesh.modetoambientwhen not explicitly specified - Updated tests to verify the new default behavior and explicitly set sidecar mode where needed
- Removed explicit ambient mode configuration from test package template to rely on the new default
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/playwright/podinfo.test.ts | Added JWT validation check after successful login |
| src/test/chart/templates/package.yaml | Commented out explicit ambient mode config to rely on default |
| src/pepr/operator/controllers/packages/package-store.ts | Added default to ambient mode when checking package mesh configuration |
| src/pepr/operator/controllers/packages/package-store.spec.ts | Updated test cases to explicitly use sidecar mode for non-ambient packages |
| src/pepr/operator/controllers/network/authorizationPolicies.ts | Added default to ambient mode in SSO client matching logic |
| src/pepr/operator/controllers/network/authorizationPolicies.spec.ts | Added test for default ambient behavior and updated existing tests to explicitly set sidecar mode |
| src/pepr/operator/controllers/istio/waypoint-utils.ts | Added default to ambient mode in waypoint decision logic |
| src/pepr/operator/controllers/istio/waypoint-utils.spec.ts | Updated test expectation to reflect ambient as the default |
| src/pepr/operator/controllers/istio/ambient-waypoint.ts | Added default to ambient mode in service and pod reconciliation logic |
| src/pepr/operator/controllers/istio/ambient-waypoint.spec.ts | Added test cases to verify default ambient behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chance-coleman
pushed a commit
that referenced
this pull request
Jan 29, 2026
🤖 I have created a release *beep* *boop* --- ## [0.60.1](v0.60.0...v0.60.1) (2026-01-29) ### Bug Fixes * ensure ambient mode is the default in all operator code ([#2326](#2326)) (backport-0.60) ([#2327](#2327)) ([287ab4d](287ab4d)) ### Miscellaneous * chore(deps): update keycloak to v26.5.2 ([#2297](#2297)) (backport-0.60) ([#2328](#2328)) ([287ab4d](6e5db83)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Sebastian Łaskawiec <sebastian.laskawiec@defenseunicorns.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of commit: bda5384