Skip to content
This repository was archived by the owner on Jul 14, 2025. It is now read-only.

align our interfaces w/ the wasi proposals#269

Merged
danbugs merged 25 commits intodeislabs:mainfrom
danbugs:danbugs/wasi-interface-alignment
Dec 14, 2022
Merged

align our interfaces w/ the wasi proposals#269
danbugs merged 25 commits intodeislabs:mainfrom
danbugs:danbugs/wasi-interface-alignment

Conversation

@danbugs
Copy link
Collaborator

@danbugs danbugs commented Dec 12, 2022

This work included:

  • renaming kv to keyvalue.
  • renaming pubsub to messaging.
  • renaming lockd to distributed_locking.
  • removal of the types.wit file:
    • giving each interface its' own error variant type, and
    • removing the payload bytes wrapper type.
  • removing mq (still to be merged onto pubsub, I'll do that in another PR).

Signed-off-by: danbugs <danilochiarlone@gmail.com>
Signed-off-by: danbugs <danilochiarlone@gmail.com>
Signed-off-by: danbugs <danilochiarlone@gmail.com>
Signed-off-by: danbugs <danilochiarlone@gmail.com>
Signed-off-by: danbugs <danilochiarlone@gmail.com>
Signed-off-by: danbugs <danilochiarlone@gmail.com>
Signed-off-by: danbugs <danilochiarlone@gmail.com>
Signed-off-by: danbugs <danilochiarlone@gmail.com>
Signed-off-by: danbugs <danilochiarlone@gmail.com>
Signed-off-by: danbugs <danilochiarlone@gmail.com>
Signed-off-by: danbugs <danilochiarlone@gmail.com>
Signed-off-by: danbugs <danilochiarlone@gmail.com>
Signed-off-by: danbugs <danilochiarlone@gmail.com>
Signed-off-by: danbugs <danilochiarlone@gmail.com>
…n a separate PR

Signed-off-by: danbugs <danilochiarlone@gmail.com>
Signed-off-by: danbugs <danilochiarlone@gmail.com>
Signed-off-by: danbugs <danilochiarlone@gmail.com>
Signed-off-by: danbugs <danilochiarlone@gmail.com>
Signed-off-by: danbugs <danilochiarlone@gmail.com>
…ng in another PR

Signed-off-by: danbugs <danilochiarlone@gmail.com>
…ted out mq references

Signed-off-by: danbugs <danilochiarlone@gmail.com>
Signed-off-by: danbugs <danilochiarlone@gmail.com>
Signed-off-by: danbugs <danilochiarlone@gmail.com>
@danbugs danbugs added the 💫 refactor Improvement or change upon an already existing feature label Dec 12, 2022
@danbugs danbugs added this to the End of Year Milestone milestone Dec 12, 2022
@danbugs danbugs requested review from Mossaka and devigned December 12, 2022 20:19
Signed-off-by: danbugs <danilochiarlone@gmail.com>
… not functioning in README and multi_capability demo

Signed-off-by: danbugs <danilochiarlone@gmail.com>
Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly looks good to me. Added some comments on WIT and slight.

Copy link
Member

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@danbugs danbugs merged commit 4b542ef into deislabs:main Dec 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

💫 refactor Improvement or change upon an already existing feature

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants

Comments