This repository was archived by the owner on Jul 14, 2025. It is now read-only.
enable handle_run to accept io redirect paths#342
Merged
devigned merged 1 commit intodeislabs:mainfrom Mar 14, 2023
Merged
Conversation
devigned
force-pushed
the
ioredirect
branch
6 times, most recently
from
ac438b5 to
7bf15d0
Compare
Member
Author
|
Going to give this a bit more testing. I'm running into 502 errors when running this in the containerd-shim. |
Mossaka
reviewed
Mar 3, 2023
Member
|
Let me know if this is ready to review again @devigned |
Member
Author
I think this last push should satisfy the linter. Should be good to go. |
devigned
commented
Mar 8, 2023
Member
Author
Mossaka
reviewed
Mar 10, 2023
Member
Mossaka
left a comment
Mossaka
left a comment
There was a problem hiding this comment.
Nice work! Left some comments
devigned
force-pushed
the
ioredirect
branch
3 times, most recently
from
06263e1 to
f084dd5
Compare
Member
Author
|
@Mossaka I've updated the PR based on your feedback. Ready for the next round of reviews. |
Signed-off-by: David Justice <david@devigned.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
handle_rundoes not enable the caller to specify I/O redirection for modules running inslight. This PR allows the caller ofhandle_runto specify paths for std{out, in, err} which will be used to redirect WASI stdio.clippy::almost_swappedcheck failing on latest nightly clap-rs/clap#4733 and fixed related lint issuesOut of scope for the PR:
slight