This repository was archived by the owner on Jul 14, 2025. It is now read-only.
refactor(slightfile): move slightfile logic to its own crate#375
Merged
refactor(slightfile): move slightfile logic to its own crate#375
Conversation
Signed-off-by: Jiaxiao Zhou <jiazho@microsoft.com>
Signed-off-by: Jiaxiao Zhou <jiazho@microsoft.com>
Signed-off-by: mossaka <duibao55328@gmail.com>
Signed-off-by: mossaka <duibao55328@gmail.com>
Signed-off-by: mossaka <duibao55328@gmail.com>
danbugs
suggested changes
Apr 2, 2023
Collaborator
danbugs
left a comment
danbugs
left a comment
There was a problem hiding this comment.
~great job w/ tests, and error messages!
I just had a few comments I think we should address before merging.
Signed-off-by: mossaka <duibao55328@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR does some preparation work for implementing the #351 feature in slightfile. It
CC @danbugs for review!