Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds automated CI validation for the CODEOWNERS file to catch configuration issues that could lead to missed reviews, security gaps, or audit problems. The check runs on every pull request as a warning-only step initially.
Key Changes:
- New GitHub Actions workflow that validates
CODEOWNERSfile integrity and team/user permissions - Updated
CODEOWNERSfile to protect the new validation workflow itself
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/codeowner-check.yml |
Defines the new CI workflow that calls a reusable validation workflow from the GHAS-enablement-repo |
.github/CODEOWNERS |
Adds ownership protection for the new codeowner-check workflow file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,13 @@ | |||
| name: CODEOWNERS Validation Call | |||
There was a problem hiding this comment.
[nitpick] The workflow name should match the filename for consistency. Consider renaming to 'Codeowner Check' or updating the filename to 'codeowners-validation-call.yml'.
| name: CODEOWNERS Validation Call | |
| name: Codeowner Check |
| * @deliveroo/team-trust | ||
| **/codeql*.yml @deliveroo/product-sec-eng # DO NOT MODIFY/REMOVE, AUTOGENERATED by Product Security | ||
| **/dependency*.yml @deliveroo/product-sec-eng # DO NOT MODIFY/REMOVE, AUTOGENERATED by Product Security | ||
| **/codeowner-check.yml @deliveroo/product-sec-eng # DO NOT MODIFY/REMOVE, AUTOGENERATED by DevSecOps |
There was a problem hiding this comment.
Corrected spelling of 'codeowner' to 'codeowners' to match GitHub's terminology and the workflow filename.
| **/codeowner-check.yml @deliveroo/product-sec-eng # DO NOT MODIFY/REMOVE, AUTOGENERATED by DevSecOps | |
| **/codeowners-check.yml @deliveroo/product-sec-eng # DO NOT MODIFY/REMOVE, AUTOGENERATED by DevSecOps |
JIRA: PSC-1944
Why this PR?
We're adding a CI/CD check to automatically validate your
CODEOWNERSfile on every commit.The Problem
Invalid or misconfigured
CODEOWNERSfiles can cause:The Solution
A new CI check will:
CODEOWNERSfile is missing or invalidFor now, this is a warning only.
We’ll make it blocking soon.
What to Do
CODEOWNERSfile and fix any issues. Confirm this PR is either updating an existing codeowners file or adding a new one.For help, ask in #support-devsecops.