Update build.yaml quality job to use lint scripts#117
Conversation
…al GitHub Actions Agent-Logs-Url: https://github.com/demaconsulting/BuildMark/sessions/230e2e9b-57cc-4586-8468-ae063d8b8173 Co-authored-by: Malcolmnixon <[email protected]>
There was a problem hiding this comment.
Pull request overview
Updates the reusable GitHub Actions workflow quality job to run the repo’s unified lint scripts instead of separate action-based linters, aligning CI behavior with the lint.sh/lint.bat single-source-of-truth approach.
Changes:
- Added
actions/setup-nodeandactions/setup-pythonsteps to supportlint.shruntime requirements. - Replaced separate Markdown/spell/YAML lint action steps with a single
bash ./lint.shinvocation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…late Agent-Logs-Url: https://github.com/demaconsulting/BuildMark/sessions/71fc480a-ce4c-4587-8df2-9e7cd94da7ba Co-authored-by: Malcolmnixon <[email protected]>
|
@copilot Your conclusion of no changes needed is utterly incorrect. I can clearly see the quality-checks job in build.yaml of this repository uses |
Agent-Logs-Url: https://github.com/demaconsulting/BuildMark/sessions/7dff002a-d086-43fe-9c56-a6ba107c3db1 Co-authored-by: Malcolmnixon <[email protected]>
Apologies for the confusion — I had referenced the wrong template repo. Confirmed that |
I think part of that was me copy-pasting the wrong link. |
Pull Request
Description
The quality job in
build.yamlwas using three individual GitHub Action linters instead of the unifiedlint.sh/lint.batscripts, causing drift from thedemaconsulting/TemplateDotNetTooltemplate pattern.Quality job changes:
Setup Node.js(node 24.x) andSetup Python(3.14) steps required bylint.shto ensure the correct runtimes are available on the CI build agentbash ./lint.shstep:DavidAnson/markdownlint-cli2-action@v22streetsidesoftware/cspell-action@v8ibiqlik/action-yamllint@v3Lint logic is now centralized in the scripts — future tooling changes only require script updates, not workflow edits. Note that
lint.shalso enforcesdotnet format --verify-no-changes, expanding the quality gate scope in CI.Type of Change
Related Issues
Pre-Submission Checklist
Before submitting this pull request, ensure you have completed the following:
Build and Test
dotnet build --configuration Releasedotnet test --configuration Releasedotnet run --project src/DemaConsulting.BuildMark --configuration Release --framework net10.0--no-build -- --validateCode Quality
dotnet format --verify-no-changesQuality Checks
Please run the following checks before submitting:
./lint.sh(Unix/macOS) orcmd /c lint.bat/./lint.bat(Windows)Testing
Documentation
Additional Notes
Aligned with
demaconsulting/TemplateDotNetTooltemplate pattern wherelint.sh/lint.batscripts are the single source of truth for quality checks in CI.